Skip to content

Fix tty tests #7613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fishrock123 merged 2 commits into from
Jul 11, 2016
Merged

Fix tty tests #7613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a3888
test: move parallel/test-tty-* to pseudo-tty/
Fishrock123 Jul 8, 2016
aab3066
test: fix old tty tests
Fishrock123 Jul 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix old tty tests 
test-tty-wrap hasn’t worked since StreamBase was introduced, I think.
test-tty-stdout-end also happens to works with PipeWrap-s.

Refs: #7360
PR-URL: #7613
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@Fishrock123
Fishrock123 committed Jul 11, 2016
commit aab306679efbf7db6cad7fcf6f4486a2b521b720
1 change: 0 additions & 1 deletion test/pseudo-tty/test-tty-stdout-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
'use strict';
// Can't test this when 'make test' doesn't assign a tty to the stdout.
require('../common');
const assert = require('assert');

Expand Down
1 change: 1 addition & 0 deletions test/pseudo-tty/test-tty-stdout-end.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

31 changes: 7 additions & 24 deletions test/pseudo-tty/test-tty-wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,11 @@
'use strict';
const common = require('../common');
var assert = require('assert');
require('../common');

var TTY = process.binding('tty_wrap').TTY;
var isTTY = process.binding('tty_wrap').isTTY;
const TTY = process.binding('tty_wrap').TTY;
const WriteWrap = process.binding('stream_wrap').WriteWrap;

if (isTTY(1) == false) {
common.skip('fd 1 is not a tty.');
return;
}
const handle = new TTY(1);
const req = new WriteWrap();

var handle = new TTY(1);
var callbacks = 0;

var req1 = handle.writeBuffer(Buffer.from('hello world\n'));
req1.oncomplete = function() {
callbacks++;
};

var req2 = handle.writeBuffer(Buffer.from('hello world\n'));
req2.oncomplete = function() {
callbacks++;
};

process.on('exit', function() {
assert.equal(2, callbacks);
});
handle.writeBuffer(req, Buffer.from('hello world 1\n'));
handle.writeBuffer(req, Buffer.from('hello world 2\n'));
2 changes: 2 additions & 0 deletions test/pseudo-tty/test-tty-wrap.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
hello world 1
hello world 2