Skip to content

build: windows sharedlib support #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefanmb wants to merge 5 commits into from
Closed

build: windows sharedlib support #7487

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1877277
WIP: Windows Shared Lib
stefanmb Jun 29, 2016
db00e24
WIP: Review Fix
stefanmb Jul 6, 2016
406d774
WIP: Use force_dynamic_crt v8 flag
stefanmb Jul 19, 2016
d2df772
WIP: Fix option value
stefanmb Jul 19, 2016
c191e89
WIP: Remove V8 changes
stefanmb Jul 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: Fix option value
  • Loading branch information
@stefanmb
stefanmb committed Jul 19, 2016
commit d2df7722d205370f75d81abb67969920b77cea83
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ def configure_v8(o):
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8)
o['variables']['force_dynamic_crt'] = int(options.shared)
o['variables']['force_dynamic_crt'] = 1 if options.shared else 0
o['variables']['node_enable_d8'] = b(options.enable_d8)
if options.enable_d8:
o['variables']['test_isolation_mode'] = 'noop' # Needed by d8.gyp.
Expand Down