Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
04c723d
tools: update cpplint to r456
bnoordhuis Jun 28, 2016
fc10624
tools: disable unwanted cpplint rules again
bnoordhuis Jun 28, 2016
bb81d69
tools: add back --mode=tap to cpplint
bnoordhuis Jun 28, 2016
fadf66a
tools: allow cpplint to run outside git repo
bnoordhuis Jun 28, 2016
19ec5d7
src: fix build/c++tr1 cpplint warnings
bnoordhuis Jun 28, 2016
e9559d0
src: fix build/header_guard cpplint warnings
bnoordhuis Jun 28, 2016
29228c4
src: fix readability/braces cpplint warnings
bnoordhuis Jun 28, 2016
df3a192
src: fix readability/constructors cpplint warnings
bnoordhuis Jun 28, 2016
8e39522
src: fix readability/inheritance cpplint warnings
bnoordhuis Jun 28, 2016
0ba0eca
src: fix readability/namespace cpplint warnings
bnoordhuis Jun 28, 2016
d112df4
src: fix readability/nolint cpplint warnings
bnoordhuis Jun 28, 2016
1243134
src: fix runtime/indentation_namespace warnings
bnoordhuis Jun 28, 2016
ae0c650
src: fix runtime/int cpplint warnings
bnoordhuis Jun 28, 2016
2f2002a
src: fix runtime/references cpplint warnings
bnoordhuis Jun 28, 2016
0daffdf
src: fix whitespace/blank_line cpplint warnings
bnoordhuis Jun 28, 2016
97aeb0a
src: fix whitespace/indent cpplint warnings
bnoordhuis Jun 28, 2016
f52e26f
build: remove unused files from CPPLINT_FILES
bnoordhuis Jun 28, 2016
a26c3cd
src: lint node_win32_perfctr_provider.cc
bnoordhuis Jun 28, 2016
f1d2792
src: lint node_lttng_tp.h
bnoordhuis Jun 28, 2016
dbe4b58
src: lint v8abbr.h
bnoordhuis Jun 28, 2016
9a6439a
tools: fix -Wunused-variable warning
bnoordhuis Jun 28, 2016
f8d3f6f
src: remove obsolete NOLINT comments
bnoordhuis Jun 28, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fix readability/inheritance cpplint warnings
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
bnoordhuis committed Jun 28, 2016
commit 8e395222de010c65110988e72068fcf2b2f09030
10 changes: 5 additions & 5 deletions src/async-wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo {
public:
explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap);

virtual void Dispose() override;
virtual bool IsEquivalent(RetainedObjectInfo* other) override;
virtual intptr_t GetHash() override;
virtual const char* GetLabel() override;
virtual intptr_t GetSizeInBytes() override;
void Dispose() override;
bool IsEquivalent(RetainedObjectInfo* other) override;
intptr_t GetHash() override;
const char* GetLabel() override;
intptr_t GetSizeInBytes() override;

private:
const char* label_;
Expand Down
2 changes: 1 addition & 1 deletion src/cares_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ class QueryWrap : public AsyncWrap {
req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));
}

virtual ~QueryWrap() override {
~QueryWrap() override {
CHECK_EQ(false, persistent().IsEmpty());
ClearWrap(object());
persistent().Reset();
Expand Down
2 changes: 1 addition & 1 deletion src/fs_event_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class FSEventWrap: public HandleWrap {

private:
FSEventWrap(Environment* env, Local<Object> object);
virtual ~FSEventWrap() override;
~FSEventWrap() override;

static void OnEvent(uv_fs_event_t* handle, const char* filename, int events,
int status);
Expand Down
2 changes: 1 addition & 1 deletion src/handle_wrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class HandleWrap : public AsyncWrap {
uv_handle_t* handle,
AsyncWrap::ProviderType provider,
AsyncWrap* parent = nullptr);
virtual ~HandleWrap() override;
~HandleWrap() override;

private:
friend class Environment;
Expand Down
9 changes: 3 additions & 6 deletions src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -240,18 +240,15 @@ class ChannelImpl final : public blink::protocol::FrontendChannel {
explicit ChannelImpl(AgentImpl* agent): agent_(agent) {}
virtual ~ChannelImpl() {}
private:
virtual void sendProtocolResponse(int callId,
const String16& message)
override {
void sendProtocolResponse(int callId, const String16& message) override {
sendMessageToFrontend(message);
}

virtual void sendProtocolNotification(
const String16& message) override {
void sendProtocolNotification(const String16& message) override {
sendMessageToFrontend(message);
}

virtual void flushProtocolNotifications() override { }
void flushProtocolNotifications() override { }

void sendMessageToFrontend(const String16& message) {
agent_->Write(message.utf8());
Expand Down
2 changes: 1 addition & 1 deletion src/node_stat_watcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace node {

class StatWatcher : public AsyncWrap {
public:
virtual ~StatWatcher() override;
~StatWatcher() override;

static void Initialize(Environment* env, v8::Local<v8::Object> target);

Expand Down