Skip to content

fs: undeprecate existsSync; use access instead of stat for performance #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfabulich wants to merge 3 commits into from
Closed

fs: undeprecate existsSync; use access instead of stat for performance #7455

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b026c0e
fs: make existsSync faster by not throwing
dfabulich Jun 28, 2016
19689e4
fs: make exists faster by using access
dfabulich Jun 28, 2016
d255e0f
fs: undeprecate existsSync
dfabulich Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fs: undeprecate existsSync 
There's no alternative method to use that doesn't throw an exception
when the file doesn't exist.
  • Loading branch information
@dfabulich
dfabulich committed Aug 16, 2016
commit d255e0fe6960dc6ae8401de13dc9898f9167c080
11 changes: 4 additions & 7 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,9 @@ deprecated: v1.0.0
* `path` {String | Buffer}
* `callback` {Function}

Test whether or not the given path exists by checking with the file system.
Then call the `callback` argument with either true or false. Example:
Test whether or not the given path exists and is accessible by checking
with the file system. Then call the `callback` argument with either
true or false. Example:

```js
fs.exists('/etc/passwd', (exists) => {
Expand All @@ -615,16 +616,12 @@ non-existent.
## fs.existsSync(path)
<!-- YAML
added: v0.1.21
deprecated: v1.0.0
-->

> Stability: 0 - Deprecated: Use [`fs.statSync()`][] or [`fs.accessSync()`][]
> instead.

* `path` {String | Buffer}

Synchronous version of [`fs.exists()`][].
Returns `true` if the file exists, `false` otherwise.
Returns `true` if the file exists and is accessible, `false` otherwise.

## fs.fchmod(fd, mode, callback)
<!-- YAML
Expand Down