Skip to content

stream: support decoding buffers for Writables #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

stream: support decoding buffers for Writables #7425

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc7b9e
stream: support decoding buffers for Writables
addaleax Jun 26, 2016
c4ea4e6
benchmark: add writable stream encoding benchmark
addaleax Jun 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
benchmark: add writable stream encoding benchmark
  • Loading branch information
@addaleax
addaleax committed Jan 6, 2017
commit c4ea4e6163600e0b11960b5e5603ce4e07057af4
35 changes: 35 additions & 0 deletions benchmark/streams/writable-simple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
'use strict';

const common = require('../common');
const Writable = require('stream').Writable;

const bench = common.createBenchmark(main, {
n: [50000],
inputType: ['buffer', 'string'],
inputEncoding: ['utf8', 'ucs2'],
decodeAs: ['', 'utf8', 'ucs2']
});

const inputStr = `袎逜 釂鱞鸄 碄碆碃 蒰裧頖 鋑, 瞂 覮轀 蔝蓶蓨 踥踕踛 鬐鶤 鄜 忁曨曣
翀胲胵, 鬵鵛嚪 釢髟偛 碞碠粻 漀 涾烰 跬 窱縓 墥墡嬇 禒箈箑, 餤駰 瀁瀎瀊 躆轖轕 蒛, 銙 簎艜薤
樆樦潏 魡鳱 櫱瀯灂 鷜鷙鷵 禒箈箑 綧 駓駗, 鋡 嗛嗕塨 嶭嶴憝 爂犤繵 罫蓱 摮 灉礭蘠 蠬襱覾 脬舑莕
躐鑏, 襆贂 漀 刲匊呥 肒芅邥 泏狔狑, 瀗犡礝 浘涀缹 輲輹 綧`;

function main(conf) {
const n = +conf.n;
const s = new Writable({
decodeBuffers: !!conf.decodeAs,
defaultEncoding: conf.decodeAs || undefined,
write(chunk, encoding, cb) { cb(); }
});

const inputEnc = conf.inputType === 'buffer' ? undefined : conf.inputEncoding;
const input = conf.inputType === 'buffer' ?
Buffer.from(inputStr, conf.inputEncoding) : inputStr;

bench.start();
for (var k = 0; k < n; ++k) {
s.write(input, inputEnc);
}
bench.end(n);
}