buffer: don't compare same buffers#742
Closed
vkurchatkin wants to merge 1 commit into
Closed
Conversation
Contributor
|
This has potential information leak implications via timing attack. |
Contributor
Author
|
Don't think it does: the underlying implementation uses Also I don't see way for attacker to trigger this branch, as it requires to send the same buffer object somehow. |
Member
|
@vkurchatkin LGTM but can you add one or two tests? |
Contributor
Author
|
@bnoordhuis just test comparing same objects? I couldn't imagine a failing test without reaching internals |
Member
|
@vkurchatkin Just some regression tests in case someone horribly botches a merge and accidentally changes the |
7d551e0 to
fbcc74c
Compare
Contributor
Author
|
added some tests |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
vkurchatkin
added a commit
that referenced
this pull request
Feb 6, 2015
PR-URL: #742 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Contributor
|
Landed in 1cd1d7a |
feross
added a commit
to feross/buffer
that referenced
this pull request
Feb 10, 2015
Copied from iojs: nodejs/node#742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@trevnorris