Skip to content

vm: don't print out arrow message for custom error #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

vm: don't print out arrow message for custom error #7398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7af968a
vm: don't print out arrow message for custom error
addaleax Jun 24, 2016
06a4039
[squash] add console.error() statement to catch block
addaleax Jun 24, 2016
4f2785d
[squash] use enum to indicate AppendExceptionLine mode
addaleax Jun 24, 2016
1d83e93
[squash] invert and explain arrow-printing logic in AppendExceptionLi…
addaleax Jun 24, 2016
3d9845b
[squash] address review comments
addaleax Jun 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] address review comments
  • Loading branch information
@addaleax
addaleax committed Jun 24, 2016
commit 3d9845b8d19f87f96c791e7569a4334c363975ef
8 changes: 4 additions & 4 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1527,10 +1527,10 @@ void AppendExceptionLine(Environment* env,
return;
}

err_obj->SetPrivate(
env->context(),
env->arrow_message_private_symbol(),
arrow_str);
CHECK(err_obj->SetPrivate(
env->context(),
env->arrow_message_private_symbol(),
arrow_str).FromMaybe(false));
}


Expand Down
2 changes: 1 addition & 1 deletion test/message/vm_caught_custom_runtime_error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const vm = require('vm');
console.error('beginning');

// Regression test for https://github.com/nodejs/node/issues/7397:
// This should not print out anything to stderr due to the error being caught.
// vm.runInThisContext() should not print out anything to stderr by itself.
try {
vm.runInThisContext(`throw ({
name: 'MyCustomError',
Expand Down