Skip to content

child_process: preserve argument type #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 6 commits into from
Closed

child_process: preserve argument type #7391

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
174f7c5
Revert "child_process: measure buffer length in bytes"
Trott Jun 22, 2016
7059a85
child_process: preserve argument type
Trott Jun 23, 2016
c9ccd19
squash: flip !encoding -> encoding
Trott Jun 26, 2016
381b0e6
squash: revise tests
Trott Jun 27, 2016
c5a3294
squash: test nits
Trott Jun 27, 2016
a3a9223
squash: fix test for Windows
Trott Jun 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: revise tests
  • Loading branch information
@Trott
Trott committed Jun 27, 2016
commit 381b0e60f461591cf2cbed81f56cda87b05da39d
35 changes: 20 additions & 15 deletions test/parallel/test-child-process-exec-maxBuffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,30 @@
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const unicode = '中文测试'; // Length = 4, Byte length = 13

if (process.argv[2] === 'stdout') {
console.log(unicode);
return;
function checkFactory(streamName) {
return common.mustCall((err) => {
const message = `${streamName} maxBuffer exceeded`;
assert.strictEqual(err.message, message);
});
}

if (process.argv[2] === 'stderr') {
console.error(unicode);
return;
{
const cmd = 'echo "hello world"';

cp.exec(cmd, { maxBuffer: 5 }, checkFactory('stdout'));
}

const cmd = `${process.execPath} ${__filename}`;
const outputs = ['stdout', 'stderr'];
{
const unicode = '中文测试'; // Length = 4, Byte length = 12
const cmd = `echo ${unicode}`;

outputs.forEach((stream) => {
const cb = common.mustCall((err, stdout, stderr) => {
assert.strictEqual(err.message, `${stream} maxBuffer exceeded`);
});
cp.exec(cmd, {maxBuffer: 10}, checkFactory('stdout'));
}

{
const unicode = '中文测试'; // Length = 4, Byte length = 12
const cmd = `echo ${unicode} 1>&2`;

cp.exec(`${cmd} ${stream}`, {maxBuffer: 10}, cb);
});
cp.exec(cmd, {maxBuffer: 10}, checkFactory('stderr'));
}
11 changes: 0 additions & 11 deletions test/parallel/test-exec-max-buffer.js
View file
Open in desktop

This file was deleted.