Skip to content

Coverity fixes, round one #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 10 commits into from
Jun 29, 2016
Merged

Coverity fixes, round one #7374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e60ded
src: check uv_async_init() return value
bnoordhuis Jun 22, 2016
88a8748
src: initialize encoding_ data member
bnoordhuis Jun 22, 2016
57387fa
src: guard against starting fs watcher twice
bnoordhuis Jun 22, 2016
664ba51
src: remove unused data member write_queue_size_
bnoordhuis Jun 22, 2016
0e82069
src: remove unused md_ data members
bnoordhuis Jun 22, 2016
d404566
src: remove duplicate HMAC_Init calls
bnoordhuis Jun 22, 2016
26a918f
src: remove deprecated HMAC_Init, use HMAC_Init_ex
bnoordhuis Jun 22, 2016
da4c1c3
src: fix use-after-return in zlib bindings
bnoordhuis Jun 22, 2016
c50e192
src: fix memory leak in WriteBuffers() error path
bnoordhuis Jun 22, 2016
ed3d8b1
src: fix bad logic in uid/gid checks
bnoordhuis Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: check uv_async_init() return value 
Pointed out by Coverity.

PR-URL: #7374
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Jun 29, 2016
commit 5e60ded244fb1651a76070d541de12d5b96d7719
6 changes: 3 additions & 3 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4096,9 +4096,9 @@ void Init(int* argc,

// init async debug messages dispatching
// Main thread uses uv_default_loop
uv_async_init(uv_default_loop(),
&dispatch_debug_messages_async,
DispatchDebugMessagesAsyncCallback);
CHECK_EQ(0, uv_async_init(uv_default_loop(),
&dispatch_debug_messages_async,
DispatchDebugMessagesAsyncCallback));
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));

#if defined(NODE_V8_OPTIONS)
Expand Down
6 changes: 3 additions & 3 deletions src/node_win32_etw_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@ void init_etw() {
event_write = (EventWriteFunc)GetProcAddress(advapi, "EventWrite");

// create async object used to invoke main thread from callback
uv_async_init(uv_default_loop(),
&dispatch_etw_events_change_async,
etw_events_change_async);
CHECK_EQ(0, uv_async_init(uv_default_loop(),
&dispatch_etw_events_change_async,
etw_events_change_async));
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_etw_events_change_async));

if (event_register) {
Expand Down