Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deps: switch to upstream v8_inspector
This change picks up v8_inspector directly from the upstream chromium
repository [1]; dropping the intermediate repository. The upstream
code has been refactored substantially to make it easy to share code
without adaptation with Node.js.

The deps/v8_inspector directory is now simply a gathering of
dependencies:

* platform/v8_inspector: vendored from [2].
* platform/inspector_protocol: vendored from [3].
* deps/jinja2: vendored from [4].
* deps/markupsafe: vendored from [5].

[1]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform
[2]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector
[3]: https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol
[4]: https://github.com/mitsuhiko/jinja2
[5]: https://github.com/mitsuhiko/markupsafe

PR-URL: #7302
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
ofrobots committed Jun 17, 2016
commit 44b9154495ede7090e90707898449feb11c5100f
1 change: 1 addition & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,7 @@ def configure_node(o):

o['variables']['asan'] = int(options.enable_asan or 0)
o['variables']['v8_inspector'] = b(not options.without_inspector)
o['variables']['debug_devtools'] = 'node'

if options.use_xcode and options.use_ninja:
raise Exception('--xcode and --ninja cannot be used together.')
Expand Down
12 changes: 10 additions & 2 deletions deps/v8_inspector/README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,10 @@
# v8_inspector
# v8_inspector
V8 Inspector support for Node.js
================================

This directory is a gathering of dependencies for Node.js support for the
[Chrome Debug Protocol][https://developer.chrome.com/devtools/docs/debugger-protocol].

* platform/v8_inspector: vendored from https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/v8_inspector
* platform/inspector_protocol: vendored from https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/platform/inspector_protocol
* deps/jinja2: vendored from https://github.com/mitsuhiko/jinja2
* deps/markupsafe: vendored from https://github.com/mitsuhiko/markupsafe
3,924 changes: 0 additions & 3,924 deletions deps/v8_inspector/devtools/Inspector-1.1.json

This file was deleted.

5,167 changes: 0 additions & 5,167 deletions deps/v8_inspector/devtools/protocol.json

This file was deleted.

66 changes: 0 additions & 66 deletions deps/v8_inspector/platform/PlatformExport.h

This file was deleted.

4 changes: 2 additions & 2 deletions deps/v8_inspector/platform/inspector_protocol/Array.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
#ifndef Array_h
#define Array_h

#include "platform/PlatformExport.h"
#include "platform/inspector_protocol/Collections.h"
#include "platform/inspector_protocol/ErrorSupport.h"
#include "platform/inspector_protocol/Platform.h"
#include "platform/inspector_protocol/String16.h"
#include "platform/inspector_protocol/ValueConversions.h"
#include "platform/inspector_protocol/Values.h"
Expand Down Expand Up @@ -91,7 +91,7 @@ class Array {
errors->addError("array expected");
return nullptr;
}
std::unique_ptr<Array<T>> result = wrapUnique(new Array<T>());
std::unique_ptr<Array<T>> result(new Array<T>());
errors->push();
for (size_t i = 0; i < array->size(); ++i) {
errors->setName(String16::number(i));
Expand Down
23 changes: 23 additions & 0 deletions deps/v8_inspector/platform/inspector_protocol/BackendCallback.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef BackendCallback_h
#define BackendCallback_h

#include "platform/inspector_protocol/ErrorSupport.h"
#include "platform/inspector_protocol/Platform.h"

namespace blink {
namespace protocol {

class PLATFORM_EXPORT BackendCallback {
public:
virtual ~BackendCallback() { }
virtual void sendFailure(const ErrorString&) = 0;
};

} // namespace platform
} // namespace blink

#endif // !defined(BackendCallback_h)
Empty file.
78 changes: 0 additions & 78 deletions deps/v8_inspector/platform/inspector_protocol/Backend_h.template

This file was deleted.

Loading