Skip to content

repl: Add editor mode support #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
princejwesley wants to merge 6 commits into from
Closed

repl: Add editor mode support #7275

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9eb96a1
repl: Add editor mode support
princejwesley Jun 12, 2016
ac1f9a2
completeOn can be undefined
princejwesley Jul 13, 2016
23e5842
Add example for editor mode
princejwesley Jul 13, 2016
233ecc5
Move longestCommonPrefix outside tab complete
princejwesley Aug 1, 2016
4134ddd
Prevent double tab behavior
princejwesley Aug 2, 2016
370616c
Fix linter issue
princejwesley Aug 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
completeOn can be undefined
  • Loading branch information
@princejwesley
princejwesley committed Aug 3, 2016
commit ac1f9a209418bd6d57565daae350d205d5317ed0
2 changes: 1 addition & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ function complete(line, callback) {
REPLServer.prototype.completeOnEditorMode = (callback) => (err, results) => {
if (err) return callback(err);

const [completions, completeOn] = results;
const [completions, completeOn = ''] = results;
const prefixLength = completeOn.length;

if (prefixLength === 0) return callback(null, [[], completeOn]);
Expand Down