Skip to content

deps: upgrade V8 from 5.1.281.49 to 5.1.281.51 #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fhinkel wants to merge 1 commit into from
Closed

deps: upgrade V8 from 5.1.281.49 to 5.1.281.51 #7020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deps: upgrade V8 from 5.1.281.49 to 5.1.281.51 
This patch brings in @indutny's fix for tickprocessor
Cpp symbols on mac into V8 5.1. So `make test`
is green again on MacOS.
  • Loading branch information
@fhinkel
fhinkel committed May 27, 2016
commit 1a14beb70f51d89919435a2f9ea4d8cc88565183
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 5
#define V8_MINOR_VERSION 1
#define V8_BUILD_NUMBER 281
#define V8_PATCH_LEVEL 49
#define V8_PATCH_LEVEL 51

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
2 changes: 0 additions & 2 deletions deps/v8/src/typing-asm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,8 +1553,6 @@ AsmTyper::VariableInfo* AsmTyper::GetVariableInfo(Variable* variable,
if (!entry && in_function_) {
entry =
global_variable_type_.Lookup(variable, ComputePointerHash(variable));
if (entry && entry->value) {
}
}
}
if (!entry) return NULL;
Expand Down
5 changes: 4 additions & 1 deletion deps/v8/tools/tickprocessor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,11 @@ inherits(MacCppEntriesProvider, UnixCppEntriesProvider);
MacCppEntriesProvider.prototype.loadSymbols = function(libName) {
this.parsePos = 0;
libName = this.targetRootFS + libName;

// It seems that in OS X `nm` thinks that `-f` is a format option, not a
// "flat" display option flag.
try {
this.symbols = [os.system(this.nmExec, ['-n', '-f', libName], -1, -1), ''];
this.symbols = [os.system(this.nmExec, ['-n', libName], -1, -1), ''];
} catch (e) {
// If the library cannot be found on this system let's not panic.
this.symbols = '';
Expand Down