Skip to content

deps: update V8 to 5.1.281.69 #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 10 commits into from
Closed

deps: update V8 to 5.1.281.69 #7016

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2cc2951
deps: update V8 to 5.1.281.69
targos May 27, 2016
b88dee2
deps: cherry-pick 1ef7487b from v8 upstream
mhdawson Apr 14, 2016
35ee1d1
v8: warn in Template::Set() on improper use
bnoordhuis Apr 19, 2016
6dfa533
deps: backport IsValid changes from 4e8736d in V8
targos May 3, 2016
78e6691
repl: fix repl after V8 upgrade
ofrobots Mar 4, 2016
0b3a366
test: fix tests after V8 upgrade
ofrobots Mar 4, 2016
4b78e09
dtrace: fix ustack helper for V8 5.1
ofrobots May 2, 2016
02c27e2
build: don't include V8 from node.gyp
targos Jun 29, 2016
cac1709
deps: revert removal of V8::PromiseEvent
Jun 6, 2016
d79df45
deps: bring in V8 5.1 - 5.0 ABI compatibility
Jun 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repl: fix repl after V8 upgrade 
V8 improved the error message for illegal token in
v8/v8@879b617b. This breaks the recoverable
error handling in repl.

PR-URL: #6482
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@ofrobots @targos
ofrobots authored and targos committed Jun 29, 2016
commit 78e6691a8971ee9f0d03faf210b0c40e9fe60e08
11 changes: 4 additions & 7 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,15 +1224,12 @@ function isRecoverableError(e, self) {
}

if (message.startsWith('Unexpected end of input') ||
message.startsWith('missing ) after argument list'))
message.startsWith('missing ) after argument list') ||
message.startsWith('Unexpected token'))
return true;

if (message.startsWith('Unexpected token')) {
if (message.includes('ILLEGAL') && bailOnIllegalToken(self.lineParser))
return false;
else
return true;
}
if (message === 'Invalid or unexpected token')
return !bailOnIllegalToken(self.lineParser);
Copy link
Copy Markdown
Member Author

@targos targos Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change this commit after #7104

}
return false;
}
Expand Down