Skip to content

test: check types for http request and response #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 1 commit into from
Jun 29, 2016
Merged

test: check types for http request and response #7003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: check types for http request and response 
Add a basic regression test that checks if the map for IncomingMessage
and OutgoingMessage objects is stable over time.

The test is not exhaustive in that it doesn't try to establish whether
the transition path is the same on every request, it just checks that
objects in their final states have the same map.

To be investigated why the first (and only the first) ServerRequest
object ends up with a deprecated map, regardless of the number of
iterations.

PR-URL: #7003
Refs: #6294
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Jun 29, 2016
commit dac16d8fb60a2aaf36f9a0a5174d04afbeef7f51
55 changes: 55 additions & 0 deletions test/parallel/test-http-same-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// Flags: --allow_natives_syntax
'use strict';

const common = require('../common');
const assert = require('assert');
const http = require('http');

const server =
http.createServer(onrequest).listen(0, common.localhostIPv4, () => next(0));

function onrequest(req, res) {
res.end('ok');
onrequest.requests.push(req);
onrequest.responses.push(res);
}
onrequest.requests = [];
onrequest.responses = [];

function next(n) {
const { address: host, port } = server.address();
const req = http.get({ host, port });
req.once('response', (res) => onresponse(n, req, res));
}

function onresponse(n, req, res) {
res.resume();

if (n < 3) {
res.once('end', () => next(n + 1));
} else {
server.close();
}

onresponse.requests.push(req);
onresponse.responses.push(res);
}
onresponse.requests = [];
onresponse.responses = [];

function allSame(list) {
assert(list.length >= 2);
// Use |elt| in no-op position to pacify eslint.
for (const elt of list) elt, eval('%DebugPrint(elt)');
for (const elt of list) elt, assert(eval('%HaveSameMap(list[0], elt)'));
}

process.on('exit', () => {
eval('%CollectGarbage(0)');
// TODO(bnoordhuis) Investigate why the first IncomingMessage ends up
// with a deprecated map. The map is stable after the first request.
allSame(onrequest.requests.slice(1));
allSame(onrequest.responses);
allSame(onresponse.requests);
allSame(onresponse.responses);
});