Skip to content

Fix windows segfault #6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kelmar wants to merge 6 commits into from
Closed

Fix windows segfault #6938

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb6f59e
Platform: Windows
May 23, 2016
1eaeb81
Adding unit test for crash on missing arguments.
May 24, 2016
ad915d0
Minor syntax change to fix styling.
May 24, 2016
f1f9a29
Reverting whitespace change
May 24, 2016
18a58af
Correcting unit test to standards
Jun 6, 2016
290d19e
Another quick change for unit tests.
Jun 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding unit test for crash on missing arguments.
  • Loading branch information
Bryce Simonds committed May 24, 2016
commit 1eaeb81818dd2d093408a70e384bc5a24ca6e381
9 changes: 7 additions & 2 deletions test/parallel/test-cli-eval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const child = require('child_process');
const path = require('path');
const nodejs = '"' + process.execPath + '"';


// replace \ by / because windows uses backslashes in paths, but they're still
Copy link
Copy Markdown
Member

@addaleax addaleax May 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you undo the whitespace changes in the lines your changes don’t touch? That helps when running e.g. git blame on a file

// interpreted as the escape character when put between quotes.
var filename = __filename.replace(/\\/g, '/');
Expand Down Expand Up @@ -66,8 +65,14 @@ child.exec(nodejs + ' --eval "require(\'./test/parallel/test-cli-eval.js\')"',
assert.equal(status.code, 42);
});

// Missing argument should not crash
child.exec(nodejs + ' -e', function (status, stdout, stderr) {
assert.notStrictEqual(status, null);
assert.equal(status.code, 9);
Copy link
Copy Markdown
Member

@addaleax addaleax May 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It’s generally preferred to use assert.strictEqual over assert.equal

Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye May 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strictEqual

});

// empty program should do nothing
child.exec(nodejs + ' -e ""', function(status, stdout, stderr) {
child.exec(nodejs + ' -e ""', function (status, stdout, stderr) {
assert.equal(stdout, '');
assert.equal(stderr, '');
});
Expand Down