Skip to content

child_process: emit IPC messages on next tick #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 4 commits into from
May 24, 2016
Merged

child_process: emit IPC messages on next tick #6909

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d59917b
child_process: emit IPC messages on next tick
cjihrig May 20, 2016
dd21bd9
test: verify IPC messages are emitted on next tick
santigimeno May 21, 2016
aadfe6c
cluster: close ownerless handles on disconnect()
cjihrig May 23, 2016
f0a07d9
test: test cluster worker disconnection on error
santigimeno May 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: test cluster worker disconnection on error 
This test checks that ownerless cluster worker handles are closed
correctly on disconnection.

Fixes: #6561
PR-URL: #6909
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@santigimeno @cjihrig
santigimeno authored and cjihrig committed May 24, 2016
commit f0a07d956e9a3cda019ead677efab4c8c4c09e9b
20 changes: 20 additions & 0 deletions test/parallel/test-cluster-worker-disconnect-on-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';
const common = require('../common');
const http = require('http');
const cluster = require('cluster');

cluster.schedulingPolicy = cluster.SCHED_NONE;

const server = http.createServer();
if (cluster.isMaster) {
server.listen(common.PORT);
const worker = cluster.fork();
worker.on('exit', common.mustCall(() => {
server.close();
}));
} else {
server.listen(common.PORT);
server.on('error', common.mustCall((e) => {
cluster.worker.disconnect();
}));
}