Skip to content

child_process: check accessing a null stderr #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertchiras wants to merge 2 commits into from
Closed

child_process: check accessing a null stderr #6877

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
646a211
child_process: Check stderr before accessing it
robertchiras May 19, 2016
91ff704
test: Additional test for execSync
robertchiras Jul 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: Additional test for execSync 
Exercise the call to execSync with a bad shell passed through options.
Verify that the right exception is thrown.

Signed-off-by: Robert Chiras <robert.chiras@intel.com>
  • Loading branch information
@robertchiras
robertchiras committed Jul 19, 2016
commit 91ff704484873390bcebabacaa97ecf16d09f84a
12 changes: 12 additions & 0 deletions test/sequential/test-child-process-execsync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@ var start = Date.now();
var err;
var caught = false;

// Verify that stderr is not accessed when a bad shell is used
assert.throws(
function() { execSync('exit -1', {shell: 'bad_shell'}); },
/spawnSync bad_shell ENOENT/,
'execSync did not throw the expected exception!'
);
assert.throws(
function() { execFileSync('exit -1', {shell: 'bad_shell'}); },
/spawnSync bad_shell ENOENT/,
'execFileSync did not throw the expected exception!'
);

try {
var cmd = `"${process.execPath}" -e "setTimeout(function(){}, ${SLEEP});"`;
var ret = execSync(cmd, {timeout: TIMER});
Expand Down