Skip to content

dgram,test: add addMembership/dropMembership tests #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

dgram,test: add addMembership/dropMembership tests #6753

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
963fce8
doc: add `added:` info for dgram.*Membership()
Trott May 16, 2016
57b62f5
dgram,test: add addMembership/dropMembership tests
Trott May 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add added: info for dgram.*Membership() 
Since I was doing the necessary git archaeology anyway, I took the time
to add YAML information to the docs about when `addMembership()` and
`dropMembership()` first appeared in their current forms.
  • Loading branch information
@Trott
Trott committed May 19, 2016
commit 963fce858a6c7d7bb74496e22dfcb3434a971441
6 changes: 6 additions & 0 deletions doc/api/dgram.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ socket.on('message', (msg, rinfo) => {
```

### socket.addMembership(multicastAddress[, multicastInterface])
<!-- YAML
added: v0.6.9
-->
Copy link
Copy Markdown
Member

@jasnell jasnell May 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should likely be done as a separate commit

Copy link
Copy Markdown
Member Author

@Trott Trott May 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


* `multicastAddress` {String}
* `multicastInterface` {String}, Optional
Expand Down Expand Up @@ -173,6 +176,9 @@ Close the underlying socket and stop listening for data on it. If a callback is
provided, it is added as a listener for the [`'close'`][] event.

### socket.dropMembership(multicastAddress[, multicastInterface])
<!-- YAML
added: v0.6.9
-->

* `multicastAddress` {String}
* `multicastInterface` {String}, Optional
Expand Down