Skip to content

vfs: place value before done in iterator result - #67231

Closed
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:vfs-lint-value-done
Closed

vfs: place value before done in iterator result#67231
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:vfs-lint-value-done

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes linting currently failing on main. The line was added in #66254 between creation and landing of #66837 which inverted the lint rule for property order.

Refs: #66837 (comment)

cc @bakkot @aduh95

@LiviaMedeiros
vfs: place value before done in iterator result
0e33594 
Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros LiviaMedeiros added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Nov 3, 2026
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2026
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2026
aduh95 pushed a commit that referenced this pull request Nov 3, 2026
@LiviaMedeiros @aduh95
vfs: place value before done in iterator result
b4b7d3d 
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: #67231
Refs: #66837
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@aduh95

aduh95 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Landed in 3930128

@aduh95 aduh95 closed this Nov 3, 2026
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.69%. Comparing base (b2913b4) to head (0e33594).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/vfs/watcher.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #67231      +/-   ##
==========================================
- Coverage   90.71%   90.69%   -0.03%     
==========================================
  Files         797      797              
  Lines      278898   278898              
  Branches    53627    53625       -2     
==========================================
- Hits       252997   252934      -63     
- Misses      16256    16309      +53     
- Partials     9645     9655      +10
Files with missing lines Coverage Δ
lib/internal/vfs/watcher.js 94.74% <0.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiviaMedeiros @aduh95 @richardlau @nodejs-github-bot