Repository navigation
bench_runner: replace Kahan summation with MathSumPrecise - #67222
Open
LiviaMedeiros wants to merge 3 commits into
Open
LiviaMedeiros wants to merge 3 commits into
LiviaMedeiros wants to merge 3 commits into
Conversation
Signed-off-by: LiviaMedeiros <livia@cirno.name>
LiviaMedeiros
force-pushed
the
bench-kahan-sumprecise
branch
from
November 3, 2026 11:05
3c7f798 to
faa106d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67222 +/- ##
==========================================
- Coverage 92.99% 90.71% -2.29%
==========================================
Files 428 797 +369
Lines 195633 278888 +83255
Branches 30268 53633 +23365
==========================================
+ Hits 181937 252986 +71049
- Misses 13369 16266 +2897
- Partials 327 9636 +9309
🚀 New features to boost your workflow:
|
aduh95
reviewed
Nov 3, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: LiviaMedeiros <livia@cirno.name>
lpinca
approved these changes
Nov 3, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
v27.xwe can sum numbers natively.