Repository navigation
test: fix zlib round-trip test parameters - #66836
Open
lluisemper wants to merge 1 commit into
Open
lluisemper wants to merge 1 commit into
lluisemper wants to merge 1 commit into
Conversation
Skip gzip with windowBits set to 8 in the PUMMEL matrix, since gzip requires a value of at least 9. Rejection of 8 is tested separately. Pass chunkSize to the compression and decompression constructors so the buffer sizes selected by the test are actually exercised. Signed-off-by: lluisemper <58423269+lluisemper@users.noreply.github.com>
lluisemper
force-pushed
the
test-zlib-round-trip-parameters
branch
from
October 18, 2026 19:24
2ef1ebe to
2a682b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PUMMEL=1, the round-trip test includes windowBits: 8 for gzip, which throws ERR_OUT_OF_RANGE. This change skips that invalid combination; a separate assertion already verifies its rejection.
It also passes chunkSize to the constructors so the selected buffer sizes are actually exercised.