Repository navigation
Conversation
Enable the existing GYP missing-source check in the Windows coverage workflow so stale references fail project generation instead of only producing warnings. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
inoway46
marked this pull request as ready for review
October 16, 2026 13:37
lpinca
approved these changes
Oct 16, 2026
cjihrig
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable GYP's existing missing-source check in Windows CI to catch stale
references after V8 updates, such as those fixed in #66531 and #66583,
before landing.
Verified that both pre-fix revisions fail project generation with the
flag enabled, and the main-based Windows build succeeds: