Repository navigation
Conversation
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Search existing directories with the directory as the glob cwd instead of appending the default glob to the path. This prevents brackets and braces in directory names from changing which tests are selected. Preserve glob arguments, node_modules filtering, and report paths. Deduplicate overlapping selections by their resolved paths. Assisted-by: Codex Signed-off-by: Casper Verbuyst <casperverbuyst@gmail.com>
37d2026 to
b4101a3
Compare
An existing directory passed to
node --testis expanded by appending the default test glob to its path. Glob metacharacters in the directory name then become active:node --test 'tests[1]'can skip its tests or run tests from a sibling namedtests1.Search from the directory itself so its path stays outside the glob pattern. Preserve explicit glob handling,
node_modulesfiltering, and report paths, while de-duplicating overlapping selections.Extend the existing CLI directory tests to cover bracket and brace names, trailing separators, and a sibling collision in both isolation modes.
Validation:
--v8-disable-temporal-support.Assisted-by: Codex