Skip to content

test: simplify worker heap profile rejection assertion - #65372

Open
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:simplify-test-worker-heap-profile.js
Open

test: simplify worker heap profile rejection assertion#65372
HoonDongKang wants to merge 1 commit into
nodejs:mainfrom
HoonDongKang:simplify-test-worker-heap-profile.js

Conversation

@HoonDongKang

Copy link
Copy Markdown
Contributor

Replaced try/catch with assert.rejects in the duplicate worker.startHeapProfile() call test for improved readability.

Refs:

Tests:

  • ./node test/parallel/test-worker-heap-profile.js
  • tools/test.py test/parallel/test-worker-heap-profile.js
[00:00|% 100|+   1|-   0]: Done                            

All tests passed.

Signed-off-by: HoonDongKang <d159123@naver.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants