test_runner: omit excluded coverage directories on the C++ side - #65371
Open
avivkeller wants to merge 1 commit into
Open
test_runner: omit excluded coverage directories on the C++ side#65371avivkeller wants to merge 1 commit into
avivkeller wants to merge 1 commit into
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
Collaborator
|
Review requested:
|
Member
Author
|
We don't have benchmarks for this yet, but a local fixture took 0.93s (after) vs 1.16s (before). Not sure if the speedup is worth the "hackiness" of JSON manipulations in this PR. (I'll fix the errors after a round of feedback) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65371 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01%
==========================================
Files 752 752
Lines 251872 251981 +109
Branches 47359 47388 +29
==========================================
+ Hits 227033 227108 +75
- Misses 16167 16187 +20
- Partials 8672 8686 +14
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By omitting the values we know will not be needed for test coverage from being serialized/deserialized, we can save time during coverage reporting.
We know that:
node:*is not included in coverage/node_modules/is not included coverage ifcoverageIncludeGlobsis not setSo, we omit on those cases.