test_runner: fix junit report on empty diagnostic - #65357
Open
lazerg wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
atlowChemi
approved these changes
Aug 17, 2026
atlowChemi
left a comment
Member
There was a problem hiding this comment.
Perhaps this should be tested with a .snapshot (see example
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-65355-junit-empty-diagnostic
branch
from
August 17, 2026 19:43
f70a693 to
0a00f28
Compare
Contributor
Author
|
Switched to a snapshot in 0a00f28. |
benjamingr
approved these changes
Aug 17, 2026
Collaborator
atlowChemi
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context.diagnostic('')makes the junit reporter throw.treeToXMLguards the comment branch withif (comment), so an empty message falls through to the element branch andObjectEntries(attrs)gets called onundefined. The generator dies, the destination stream is destroyed, and the report is left without its closing</testsuites>.Comment nodes are already identified by
comment == nullelsewhere in the reporter, so the guard now checks the same way and an empty diagnostic renders as an empty XML comment.Fixes: #65355