ffi: validate the value passed to the float setters - #65342
Open
soulee-dev wants to merge 1 commit into
Open
Conversation
setInt8() through setUint64() require IsNumber() before any range check and reject anything else with ERR_INVALID_ARG_VALUE, but setFloat32() and setFloat64() call ToNumber() and write whatever it returns, so a string, a boolean or a plain object is converted instead of rejected and a typo such as '1,5' stores NaN in native memory with no error at the call site. The same double is type-checked when it is passed as a call argument: ToFFIArgument() requires IsNumber() and otherwise throws "Argument %s must be a double". The coercion also discards a pending exception. When ToNumber() fails because the value has a valueOf() that throws, the branch throws ERR_INVALID_ARG_VALUE on top of the exception V8 has already scheduled, so the original error never reaches the caller, whereas DataView.prototype.setFloat64() and Buffer.prototype.writeDoubleLE() both propagate it. Check IsNumber() instead, matching the wording of the integer setters and of ToFFIArgument(). The check runs before any conversion, so valueOf() is never invoked and there is no pending exception left to discard. This was the only ToNumber(context) call in src/. Signed-off-by: Soul Lee <alus20x@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65342 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01%
==========================================
Files 752 752
Lines 251569 251567 -2
Branches 47268 47266 -2
==========================================
+ Hits 226701 226725 +24
+ Misses 16233 16189 -44
- Partials 8635 8653 +18
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every other setter in
SetValue<T>()requiresIsNumber()before it writes, sosetInt8(ptr, 0, '5')throws. The floating-point branch callsToNumber()instead, sosetFloat64(ptr, 0, '1.5')writes1.5,{}writesNaNandnullwrites0. The samedoubleis type-checked on the argument path, whereToFFIArgument()throwsArgument %s must be a double, and the documentation already says the setters "validate the supplied JavaScript value against the target native type before writing it into memory".ToNumber()also discards a pending exception. When the value has avalueOf()that throws, the branch callsTHROW_ERR_INVALID_ARG_VALUEon top of the exception V8 has already scheduled, so the caller seesValue must be a numberinstead of their own error.DataView.prototype.setFloat64()andBuffer.prototype.writeDoubleLE()both propagate it, andsrc/README.mdasks for an early return instead.Fix
Check
IsNumber()instead. It runs before any conversion, sovalueOf()is never invoked and there is no pending exception left to discard. The messages follow the integer setters andToFFIArgument()rather than the old genericValue must be a number.Compatibility
NaNandInfinitystill pass, since both arenumbervalues; only the type check is new. This makes input that is accepted today throw, butnode:ffiis experimental and the recent fixes in this area went the same way without asemver-majorlabel.Tests
Six assertions are added to the setter block in
test/ffi/test-ffi-memory.js, which covered only the integer setters. The last one passes{ valueOf: common.mustNotCall() }, so the test fails if the setter ever converts the value again.Fixes: #65341
Refs: #62858
Refs: #64614
Refs: #64691
Refs: #65032