Skip to content

quic: update writedesiredsize on maxdataframe - #65306

Draft
martenrichter wants to merge 1 commit into
nodejs:mainfrom
martenrichter:callbackformaxdata
Draft

quic: update writedesiredsize on maxdataframe#65306
martenrichter wants to merge 1 commit into
nodejs:mainfrom
martenrichter:callbackformaxdata

Conversation

@martenrichter

Copy link
Copy Markdown
Contributor

This commit will react on a callback from
ngtcp2, when a maxdata frame arrives and
update the scheduled streams accordingly.
A PR to get this callback is pending.

Fixes: #64835

This commit will react on a callback from
ngtcp2, when a maxdata frame arrives and
update the scheduled streams accordingly.
A PR to get this callback is pending.

Fixes: nodejs#64835

Signed-off-by: Marten Richter <marten.richter@freenet.de>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 15, 2026
@martenrichter

Copy link
Copy Markdown
Contributor Author

I have just committed a PR to ngtcp2/ngtcp2#2283 .
So until this PR is accepted and the ngtcp2 version is landing in node.js. This is a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quic: buffer stalls, as maxdata updates do not triggern an update of writeDesired sizes

2 participants