Skip to content

[v26.x backport] repl: add basic syntax highlighting - #65267

Draft
avivkeller wants to merge 1 commit into
nodejs:v26.x-stagingfrom
avivkeller:backport
Draft

[v26.x backport] repl: add basic syntax highlighting#65267
avivkeller wants to merge 1 commit into
nodejs:v26.x-stagingfrom
avivkeller:backport

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 13, 2026

Copy link
Copy Markdown
Member

Backport of #64591 (4a5eb1c)

@avivkeller
repl: add basic syntax highlighting
a812691 
Signed-off-by: avivkeller <me@aviv.sh>
PR-URL: nodejs#64591
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels Aug 13, 2026
@avivkeller
avivkeller marked this pull request as draft August 13, 2026 18:54
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.13084% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.21%. Comparing base (54929af) to head (a812691).
⚠️ Report is 324 commits behind head on v26.x-staging.

Files with missing lines Patch % Lines
lib/internal/repl/highlight.js 97.75% 2 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           v26.x-staging   #65267      +/-   ##
=================================================
+ Coverage          90.19%   90.21%   +0.01%     
=================================================
  Files                737      730       -7     
  Lines             240370   242812    +2442     
  Branches           45490    46055     +565     
=================================================
+ Hits              216797   219046    +2249     
- Misses             15107    15215     +108     
- Partials            8466     8551      +85
Files with missing lines Coverage Δ
lib/internal/readline/interface.js 97.32% <100.00%> (-0.02%) ⬇️
lib/internal/util/inspect.js 96.93% <100.00%> (+<0.01%) ⬆️
lib/repl.js 90.83% <100.00%> (-3.19%) ⬇️
lib/internal/repl/highlight.js 97.75% <97.75%> (ø)

... and 236 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 changed the title repl: add basic syntax highlighting [v26.x backport] repl: add basic syntax highlighting Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avivkeller @nodejs-github-bot