doc: mark Resolver.setLocalAddress ipv4 as required - #65190
Closed
arhxam wants to merge 1 commit into
Closed
Conversation
The implementation unconditionally validates ipv4 as a string, so omitting it throws ERR_INVALID_ARG_TYPE. Only ipv6 is optional. Update the signature, parameter default, and explanatory text to match. Signed-off-by: Arham Wani <arhamwani765@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolver#setLocalAddress()documentsipv4as optional with a default of'0.0.0.0'. The implementation unconditionally validatesipv4as a string,so omitting it throws
ERR_INVALID_ARG_TYPE; onlyipv6is optional.This marks
ipv4as required, removes its nonexistent default, and clarifiesthat the operating system chooses the IPv6 local address when
ipv6isomitted. Documentation-only change.