doc: correct HTTP/2 HTTP/1 keepAliveTimeout default - #65189
Closed
arhxam wants to merge 1 commit into
Closed
Conversation
HTTP/2 passes http1Options to storeHTTPOptions() when HTTP/1 fallback is enabled. An omitted keepAliveTimeout therefore uses the current HTTP server default of 65 seconds, not 5 seconds. Correct both API entries and record the underlying default change. Signed-off-by: Arham Wani <arhamwani765@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both
http2.createServer()andhttp2.createSecureServer()document thedefault
http1Options.keepAliveTimeoutas 5000 milliseconds.When HTTP/1 fallback is enabled, HTTP/2 passes
http1OptionstostoreHTTPOptions(). An omitted value therefore receives the current HTTPserver default of 65000 milliseconds, not 5000. A secure HTTP/2 server created
with
allowHTTP1: truereportsserver.keepAliveTimeout === 65000.This updates both API entries and records the underlying default change.
Documentation-only change.