doc: correct HTTPS server defaults - #65188
Closed
arhxam wants to merge 1 commit into
Closed
Conversation
HTTPS servers inherit their timeout behavior from HTTP. The setTimeout() entry still listed 120 seconds after the v13 default change, and the keepAliveTimeout entry still listed 5 seconds after the HTTP default became 65 seconds. Update both entries and their change metadata. Signed-off-by: Arham Wani <arhamwani765@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two HTTPS server defaults remained stale after their underlying HTTP server
defaults changed:
https.Server.setTimeout()documented 120 seconds, while HTTPS servers settimeoutto0and the inherited HTTP default has been0since v13.0.0.https.Server.keepAliveTimeoutdocumented 5 seconds, whilestoreHTTPOptions()now initializes it to 65 seconds, matchinghttp.Server.keepAliveTimeout.A newly created HTTPS server confirms both effective defaults:
{ timeout: 0, keepAliveTimeout: 65000 }This corrects both entries and mirrors the relevant HTTP changelog metadata.
Documentation-only change.