doc: add AES-OCB to aesKeyGenParams.name - #65181
Open
arhxam wants to merge 1 commit into
Open
Conversation
The `aesKeyGenParams.name` value list omitted `'AES-OCB'`, but AES-OCB key generation is dispatched through the `AesKeyGenParams` dictionary in lib/internal/crypto/util.js and works at runtime. The sibling `aesDerivedKeyParams.name` list and the list of algorithms supported by `generateKey()` in the same document already include `'AES-OCB'`. Add it so the value lists are consistent. Signed-off-by: Arham Wani <arhamwani765@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
aesKeyGenParams.namevalue list indoc/api/webcrypto.mdomits'AES-OCB', even though AES-OCB key generation is supported:lib/internal/crypto/util.jsdispatchesAES-OCB'sgenerateKeythrough the
AesKeyGenParamsdictionary, and it works at runtime:The sibling
aesDerivedKeyParams.namelist in the same documentalready includes
'AES-OCB', and so does the list of algorithmssupported by
generateKey()— so the omission is an internalinconsistency.
This adds
'AES-OCB'to theaesKeyGenParams.namelist so the valuelists agree. Documentation-only change.