tools: make env variables consistent in cron jobs - #65168
Open
aduh95 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-R/--repoexplicitly instead of an implicit use ofGH_REPOor let the tool figure out based on the local repoGH_TOKEN, since that's whatghchecks first according to https://cli.github.com/manual/gh_help_environmentgithub.tokenoversecrets.GITHUB_TOKENto help avoid confusing it withsecrets.GH_USER_TOKEN=auto-start-ci.yml, remove references tosecrets.GH_USER_TOKENownerandrepositoryas argv forcommit-queue.sh, it already expects to find e.g.GITHUB_SERVER_URLin the env, it's simpler for it to also expectGITHUB_REPOSITORYto be defined.