util: keep function name for mapped call sites - #65107
Open
lazerg wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-65104-callsite-function-name
branch
from
August 7, 2026 15:14
9e9d99b to
60488c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 759 759
Lines 248290 248290
Branches 46859 46853 -6
=======================================
Hits 224241 224241
+ Misses 15472 15470 -2
- Partials 8577 8579 +2
🚀 New features to boost your workflow:
|
Contributor
Author
|
The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
getCallSites({ sourceMap: true })remaps a frame,reconstructCallSite()usesentry.name ?? ''. Thenamesarray is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us andfunctionNamecomes back empty.Fall back to the generated call site's
functionNameinstead, which is what the source-mapped stack trace formatter inlib/internal/source_map/prepare_stack_trace.jsalready does.Fixes: #65104