Skip to content

tools: delay removal of commit-queue label - #65101

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:cq-label-defer-removal
Open

tools: delay removal of commit-queue label#65101
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:cq-label-defer-removal

Conversation

@aduh95

@aduh95 aduh95 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The removes the possiblity for a PR to drop from the queue if the CQ job is cancelled (or times out) in the middle of handling a PR. This increases the window for two concurrent CQ jobs to pick up the same PR, but that's an unlikely scenario.

Alternative to #65005
Refs: #64972

The removes the possiblity for a PR to drop from the queue if the CQ job
is cancelled (or times out) in the middle of handling a PR.
This increases the window for two concurrent CQ jobs to pick up the same
PR, but that's an unlikely scenario.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 7, 2026
@Renegade334

Copy link
Copy Markdown
Member

This increases the window for two concurrent CQ jobs to pick up the same PR, but that's an unlikely scenario.

We set a GHA concurrency token, so I think this should be safe!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants