Skip to content

tools: update ESLint to 2.9.0 #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

tools: update ESLint to 2.9.0 #6498

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1147e
lib,test: update in preparation for linter update
Trott May 1, 2016
5fee48d
tools: update ESLint to 2.9.0
Trott May 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib,test: update in preparation for linter update 
ESLint 2.9.0 fixes some bugs that resulted in minor issues not being
caught by ESLint 2.7.0. Update instances of our code that will be
flagged when we upgrade to ESLint 2.9.0.
  • Loading branch information
@Trott
Trott committed May 1, 2016
commit 5a1147e8da06b8f28a74aad0967ead1a833cbca3
1 change: 1 addition & 0 deletions lib/internal/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

// Regexes used for ansi escape code splitting
// eslint-disable-next-line no-control-regex
const metaKeyCodeReAnywhere = /(?:\x1b)([a-zA-Z0-9])/;
const functionKeyCodeReAnywhere = new RegExp('(?:\x1b+)(O|N|\\[|\\[\\[)(?:' + [
'(\\d+)(?:;(\\d+))?([~^$])',
Expand Down
7 changes: 6 additions & 1 deletion test/parallel/test-http-destroyed-socket-write2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,17 @@ server.listen(common.PORT, function() {
switch (er.code) {
// This is the expected case
case 'ECONNRESET':
// On windows this sometimes manifests as ECONNABORTED
break;

// On Windows, this sometimes manifests as ECONNABORTED
case 'ECONNABORTED':
break;

// This test is timing sensitive so an EPIPE is not out of the question.
// It should be infrequent, given the 50 ms timeout, but not impossible.
case 'EPIPE':
break;

default:
assert.strictEqual(er.code,
'ECONNRESET',
Expand Down