Skip to content

test_runner: convert to uint during deserialization#64706

Open
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:deserialize-to-uint
Open

test_runner: convert to uint during deserialization#64706
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:deserialize-to-uint

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 24, 2026

Copy link
Copy Markdown
Member

Fixes #64061 by adding >>> 0 (to convert to a uint) in our test runner's processRawBuffer, similarly to how we do in child_process.

cc @nodejs/test_runner @MoLow

@avivkeller
test_runner: convert to uint during deserialization
6372776 
Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller added the test_runner Issues and PRs related to the test runner subsystem. label Jul 24, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (e383a1d) to head (6372776).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64706      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.02%     
==========================================
  Files         741      741              
  Lines      242241   242241              
  Branches    45617    45627      +10     
==========================================
- Hits       218366   218318      -48     
- Misses      15361    15394      +33     
- Partials     8514     8529      +15
Files with missing lines Coverage Δ
lib/internal/test_runner/runner.js 94.42% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75088/

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75093/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@JakobJingleheimer JakobJingleheimer Awaiting requested review from JakobJingleheimer

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Unable to deserialize cloned data due to invalid or unsupported version

3 participants

@avivkeller @nodejs-github-bot @MoLow