src: fix out-of-bounds write in ucs2 encode of unaligned buffer#64697
Open
Nashit-h wants to merge 1 commit into
Open
src: fix out-of-bounds write in ucs2 encode of unaligned buffer#64697Nashit-h wants to merge 1 commit into
Nashit-h wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64697 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 741 741
Lines 242112 242158 +46
Branches 45605 45610 +5
=======================================
+ Hits 218244 218295 +51
+ Misses 15360 15346 -14
- Partials 8508 8517 +9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringBytes::Encode decodes a ucs2 slice whose data pointer is 2-byte unaligned through a branch that allocates buflen/2 code units but memcpy's the full byte length, so an odd-length slice at an odd start offset (reachable from Buffer.prototype.toString('ucs2', start, end)) writes one byte past the destination. Copy only whole code units so the copy matches the allocation and the aligned path, which already drops the trailing odd byte.