http: emit aborted event on requests#64693
Open
simhnna wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#46666 Signed-off-by: Simon Hanna <simon.hanna@aeb.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the aborted event is never emitted on the request object. This merge request fixes that by ensuring the abort event is emitted on the request if the server hasn't finished reading the request or the response sending the response hasn't finished yet. It also improved the documentation to make it clear when close and abort events are emitted.
Fixes: #46666
I would welcome reverting the deprecation from the req aborted event, but didn't do that here. IMO it's much nicer for devs to be able to listen for client aborts in a single place (the request object).