Skip to content

wasm: reject non-Uint8Array streaming chunks#64670

Open
Archkon wants to merge 2 commits into
nodejs:mainfrom
Archkon:wasm
Open

wasm: reject non-Uint8Array streaming chunks#64670
Archkon wants to merge 2 commits into
nodejs:mainfrom
Archkon:wasm

Conversation

@Archkon

@Archkon Archkon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64669

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 22, 2026
@Archkon
wasm: reject non-Uint8Array streaming chunks
6d7964a 
Restrict WebAssembly streaming response chunks to Uint8Array, as
required by Fetch body consumption.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 22, 2026
@jasnell

jasnell commented Jul 22, 2026

Copy link
Copy Markdown
Member

This would be a semver-major change.

That said, I'm not super convinced that it's worthwhile. Won't block, however.

@Archkon

Archkon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

This would be a semver-major change.

That said, I'm not super convinced that it's worthwhile. Won't block, however.

Many thanks! I just meant to align the behavior with the corresponding web api. This would lead better developer experience

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (594d0c5) to head (76c5435).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/node_wasm_web_api.cc 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #64670   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         741      741           
  Lines      242149   242200   +51     
  Branches    45574    45606   +32     
=======================================
+ Hits       218229   218289   +60     
+ Misses      15447    15391   -56     
- Partials     8473     8520   +47
Files with missing lines Coverage Δ
src/node_wasm_web_api.cc 67.61% <57.14%> (+4.22%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
jasnell requested a review from guybedford July 22, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedford guybedford Awaiting requested review from guybedford

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wasm: streaming APIs accept non-Uint8Array response body chunks

3 participants

@Archkon @jasnell @nodejs-github-bot