Skip to content

src: avoid using ToLocalChecked in crypto_hash#64668

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/minor-improvements-nits
Open

src: avoid using ToLocalChecked in crypto_hash#64668
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/minor-improvements-nits

Conversation

@jasnell

@jasnell jasnell commented Jul 22, 2026

Copy link
Copy Markdown
Member

And other minor cleanups

Signed-off-by: James M Snell jasnell@gmail.com

@jasnell
src: avoid using ToLocalChecked in crypto_hash
e00d851 
And other minor cleanups

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 22, 2026
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecov Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (594d0c5) to head (e00d851).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_hash.cc 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64668      +/-   ##
==========================================
+ Coverage   90.12%   90.13%   +0.01%     
==========================================
  Files         741      741              
  Lines      242149   242151       +2     
  Branches    45574    45567       -7     
==========================================
+ Hits       218229   218270      +41     
+ Misses      15447    15373      -74     
- Partials     8473     8508      +35
Files with missing lines Coverage Δ
src/crypto/crypto_hash.cc 73.78% <88.88%> (+0.28%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75012/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell @nodejs-github-bot @panva