Skip to content

util: fix inspecting of proxy objects #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 6 commits into from
Closed

util: fix inspecting of proxy objects #6465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86daa71
util: fix inspecting of proxy objects
jasnell Apr 29, 2016
ec16e91
Address nits
jasnell Apr 30, 2016
b2ebb7b
Cache the results to avoid duplicate lookups, add option
jasnell Apr 30, 2016
f630602
Reworked based on @bnoordhuis' feedback
jasnell Apr 30, 2016
6115df5
Fix doc nit
jasnell Apr 30, 2016
842a8e4
Address nits
jasnell May 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address nits
  • Loading branch information
@jasnell
jasnell committed Apr 30, 2016
commit ec16e916dfb21340e17a74d1b9246f503e47bffb
16 changes: 0 additions & 16 deletions doc/api/util.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,22 +478,6 @@ util.isPrimitive(new Date())
// false
```

## util.isProxy(object)

Returns `true` if the given "object" is a `Proxy` object. Otherwise, returns
`false`.

```js
const util = require('util');
const proxyObj = new Proxy({}, {get: () => { return 5; }});

util.isProxy(proxyObj);
// true

util.isProxy({});
// false
```

## util.isRegExp(object)

Stability: 0 - Deprecated
Expand Down
7 changes: 1 addition & 6 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ function inspectPromise(p) {

function formatValue(ctx, value, recurseTimes) {

if (isProxy(value)) {
if (binding.isProxy(value)) {
return 'Proxy ' + formatValue(ctx,
binding.getProxyDetails(value),
recurseTimes);
Expand Down Expand Up @@ -792,11 +792,6 @@ exports.isPrimitive = isPrimitive;

exports.isBuffer = Buffer.isBuffer;

function isProxy(p) {
return binding.isProxy(p);
}
exports.isProxy = isProxy;

function pad(n) {
return n < 10 ? '0' + n.toString(10) : n.toString(10);
}
Expand Down
6 changes: 2 additions & 4 deletions test/parallel/test-util-inspect-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ const handler = {
};
const proxyObj = new Proxy(target, handler);

assert.strictEqual(util.isProxy(proxyObj), true);

// Inspecting the proxy should not actually walk it's properties
assert.doesNotThrow(() => util.inspect(proxyObj));

// getProxyDetails is an internal method, not intended for public use.
// This is here to test that the internals are working correctly.
const details = processUtil.getProxyDetails(proxyObj);
assert.deepStrictEqual(target, details.target);
assert.deepStrictEqual(handler, details.handler);
Expand All @@ -25,5 +25,3 @@ assert.strictEqual(util.inspect(proxyObj),

// Using getProxyDetails with non-proxy returns undefined
assert.strictEqual(processUtil.getProxyDetails({}), undefined);
// isProxy with non-Proxy returns false
assert.strictEqual(util.isProxy({}), false);