stream: copy SAB-backed chunks in iter consumers#64382
Open
trivikr wants to merge 1 commit into
Open
Conversation
Ensure bytes() copies single chunks backed by SharedArrayBuffer so arrayBuffer() and arrayBufferSync() return ArrayBuffer instances as specified. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64382 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 741 741
Lines 241194 241197 +3
Branches 45432 45427 -5
==========================================
Hits 217640 217640
+ Misses 15129 15124 -5
- Partials 8425 8433 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64381
This updates the
stream/iterbyte consumers to avoid preservingSharedArrayBufferbacking stores when collecting a single full-buffer chunk.bytes()andbytesSync()now copy SAB-backed chunks into a newUint8Array, andarrayBuffer()/arrayBufferSync()defensively copySAB-backed data into a normal
ArrayBuffer.The existing SharedArrayBuffer stream/iter test coverage has been tightened to
assert that SAB-backed input produces non-shared output for these consumers.
Assisted-by: openai:gpt-5.5