Skip to content

test: fix flaky watch + cwd + argv test-runner test #64372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −8
Open

test: fix flaky watch + cwd + argv test-runner test #64372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// parent process argv when spawning the watch child.
import * as common from '../common/index.mjs';
import assert from 'node:assert';
import { readFileSync, writeFileSync } from 'node:fs';
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { run } from 'node:test';
import tmpdir from '../common/tmpdir.js';
Expand All @@ -11,16 +11,13 @@ import { skipIfNoWatch } from '../common/watch.js';
skipIfNoWatch();
tmpdir.refresh();

const marker = join(tmpdir.path, 'marker');
writeFileSync(join(tmpdir.path, 'test.js'), `
const test = require('node:test');
const { writeFileSync } = require('node:fs');

test('test ran from cwd', () => {
writeFileSync(${JSON.stringify(marker)}, 'ran');
});
test('test ran from cwd', () => {});
`);

const passed = [];
const controller = new AbortController();
const stream = run({
cwd: tmpdir.path,
Expand All @@ -36,8 +33,9 @@ const stream = run({
});

stream.on('test:fail', common.mustNotCall());
stream.on('test:pass', common.mustCall(1));
stream.on('test:pass', common.mustCall((data) => passed.push(data.name), 1));
// eslint-disable-next-line no-unused-vars
for await (const _ of stream);

assert.strictEqual(readFileSync(marker, 'utf8'), 'ran');
// Validate the expected test ran by name:
assert.deepStrictEqual(passed, ['test ran from cwd']);
Loading