test_runner: display diagnostic messages in dot reporter#64331
Open
armorbreak001 wants to merge 1 commit into
Open
test_runner: display diagnostic messages in dot reporter#64331armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
When using the dot reporter with coverage enabled, coverage failures would silently exit with an error code but show no output explaining the failure. This change collects and displays diagnostic messages (including coverage warnings) after the test dots, similar to how failed tests are displayed. Fixes: nodejs#60884 Signed-off-by: armorbreak001 <contact@agentvote.cc>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running tests with both the dot reporter (
--test-reporter dot) and coverage enabled, if coverage setup or collection fails, the process exits with a non-zero status code but shows no output explaining why. The user only sees test dots and then an unexplained failure.Proposed Fix
Collect
test:diagnosticevents in the dot reporter and display them after the test results (similar to how failed tests are shown). This ensures coverage warnings and other diagnostic messages are visible.Changes
lib/internal/test_runner/reporter/dot.js:diagnostics[]array to collect diagnostic eventstest:diagnostictype in the event loop!prefix)Before
After
Approach
Fixes: #60884