Skip to content

http: create header field names as internalized strings #64277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
araujogui wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

http: create header field names as internalized strings #64277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ using v8::Isolate;
using v8::Local;
using v8::LocalVector;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Number;
using v8::Object;
using v8::ObjectTemplate;
Expand Down Expand Up @@ -233,6 +234,17 @@ struct StringPtr {
return String::Empty(env->isolate());
}

Local<String> ToInternalizedString(Environment* env) const {
if (size_ != 0) {
return String::NewFromOneByte(env->isolate(),
reinterpret_cast<const uint8_t*>(str_),
NewStringType::kInternalized,
size_)
.ToLocalChecked();
}
return String::Empty(env->isolate());
}
Comment on lines +237 to +246

// Strip trailing OWS (SPC or HTAB) from string.
Local<String> ToTrimmedString(Environment* env) {
while (size_ > 0 && IsOWS(str_[size_ - 1])) {
Expand Down Expand Up @@ -940,7 +952,8 @@ class Parser : public AsyncWrap, public StreamListener {
Local<Value> headers_v[kMaxHeaderFieldsCount * 2];

for (size_t i = 0; i < num_values_; ++i) {
headers_v[i * 2] = fields_[i].ToString(env());
// Field names repeat across requests, so internalize them.
headers_v[i * 2] = fields_[i].ToInternalizedString(env());
headers_v[i * 2 + 1] = values_[i].ToTrimmedString(env());
}

Expand Down
Loading