Skip to content

test: remove impact of tier-up changes in worker stack size test #64271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

test: remove impact of tier-up changes in worker stack size test #64271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/parallel/test-worker-stack-overflow-stack-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ const { Worker } = require('worker_threads');
// Verify that Workers don't care about --stack-size, as they have their own
// fixed and known stack sizes.

// The depth of the stack depends not only on the stack size, but also on the size of each
// stack frame, which in turn depends on which tier the recursive function happens to be
// running at when the overflow occurs. Under load the background tier-up can land at a
// non-deterministic point in the recursion and flake the test. Keep the recursive
// function in the interpreter with %NeverOptimizeFunction() so the frame size -
// and thus the depth - is deterministic.
v8.setFlagsFromString('--allow-natives-syntax');

async function runWorker(options = {}) {
const empiricalStackDepth = new Uint32Array(new SharedArrayBuffer(4));
const worker = new Worker(`
Expand All @@ -16,6 +24,7 @@ async function runWorker(options = {}) {
empiricalStackDepth[0]++;
f();
}
%NeverOptimizeFunction(f);
f();`, {
eval: true,
workerData: { empiricalStackDepth },
Expand Down
Loading