Skip to content

lib: fix missing lazyDOMException import#64033

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-missing-lazyDOMException
Closed

lib: fix missing lazyDOMException import#64033
panva wants to merge 1 commit into
nodejs:mainfrom
panva:fix-missing-lazyDOMException

Conversation

@panva

@panva panva commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes a missing lazyDOMException in lib/internal/crypto/hash.js relied upon when openssl < 3 or boringssl is used by #63988 that was removed just before in #63975.

I apologize for the noise.

@panva
lib: fix missing lazyDOMException import
0db3c4a 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74311/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2026
@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 20, 2026
panva added a commit that referenced this pull request Jun 20, 2026
@panva
lib: fix missing lazyDOMException import
8c8c438 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64033
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@panva

panva commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

Landed in 8c8c438

@panva panva closed this Jun 20, 2026
@panva panva deleted the fix-missing-lazyDOMException branch June 20, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva @nodejs-github-bot @Renegade334 @aduh95