Skip to content

Revert handle wrap refed check #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fishrock123 wants to merge 3 commits into from
Closed

Revert handle wrap refed check #6401

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
635fb96
Revert "handle_wrap: IsRefed -> Unrefed, no isAlive check"
Fishrock123 Apr 26, 2016
6b025df
Revert "src: fix -Wunused-variable compiler warning"
Fishrock123 Apr 26, 2016
80a2229
Revert "handle_wrap: expose an `isRefed()` check to JS"
Fishrock123 Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "src: fix -Wunused-variable compiler warning" 
This reverts commit f938ef7.

Refs: #6382
Refs: #6204
Refs: #5834
  • Loading branch information
@Fishrock123
Fishrock123 committed Apr 26, 2016
commit 6b025df39b3b2d35130b9005bcc5f35de69527e9
1 change: 1 addition & 0 deletions src/handle_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ void HandleWrap::Unref(const FunctionCallbackInfo<Value>& args) {


void HandleWrap::IsRefed(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
HandleWrap* wrap = Unwrap<HandleWrap>(args.Holder());

bool refed = IsAlive(wrap) && (wrap->flags_ & kUnref) == 0;
Expand Down